Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

I signed it!

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

This PR (HEAD: 8d5fff1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/164963 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

Message from Bryan C. Mills:

Patch Set 1:

(2 comments)

Thanks for the fix! A couple of minor comments.

Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

This PR (HEAD: ae998de) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/164963 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Message from Yuki Okamoto:

Patch Set 2:

(2 comments)

Patch Set 1:

(2 comments)

Thanks for the fix! A couple of minor comments.

Thanks for your prompt review!
I just updated the pull request based on your review.

Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

Message from Emmanuel Odeke:

Patch Set 2: Run-TryBot+1 Code-Review+1

Nice, thank you Yuki!

Bryan I am just running the tests, merging all yours.

Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=54991d2a

Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

Message from Gobot Gobot:

Patch Set 2:

Build is still in progress...
This change failed on linux-amd64:
See https://storage.googleapis.com/go-build-log/54991d2a/linux-amd64_6e07ca85.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.

Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

Message from Gobot Gobot:

Patch Set 2: TryBot-Result-1

2 of 19 TryBots failed:
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/54991d2a/linux-amd64_6e07ca85.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/54991d2a/windows-amd64-2016_ae1365df.log

Consult https://build.golang.org/ to see whether they are new failures.

Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

Message from Yuki Okamoto:

Patch Set 2:

Patch Set 1:

(2 comments)

Thanks for the fix! A couple of minor comments.

Hi Bryan!

I applied the fixes but it seemed to break a few tests on some platforms unfortunately.

Let me confirm if my understanding is correct.

'testKillTimeout' is just a backup alarm as described in the following comment.

• https://github.com/golang/go/blob/master/src/cmd/go/internal/test/test.go#L551

Then, 'dt' itself in the following code (which is originally specified with '-timeout' option) should be passed to test programs as 'test.timeout' flag, right?

• https://github.com/golang/go/blob/master/src/cmd/go/internal/test/test.go#L554

Cheers,
Yuki

Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

This PR (HEAD: 66f9a6f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/164963 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Message from Bryan C. Mills:

Patch Set 3: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

Message from Gobot Gobot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=427c525d

Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

Message from Gobot Gobot:

Patch Set 3:

Build is still in progress...
This change failed on misc-vet-vetall:
See https://storage.googleapis.com/go-build-log/427c525d/misc-vet-vetall_2eddc49b.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

Message from Bryan C. Mills:

Patch Set 4: Patch Set 3 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

Message from Bryan C. Mills:

Patch Set 4: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e6a864b3

Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

Message from Gobot Gobot:

Patch Set 3: TryBot-Result-1

1 of 19 TryBots failed:
Failed on misc-vet-vetall: https://storage.googleapis.com/go-build-log/427c525d/misc-vet-vetall_2eddc49b.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

Message from Gobot Gobot:

Patch Set 4: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

This PR is being closed because golang.org/cl/164963 has been merged.